Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCM integration tests failing due to missing label on Machine object #960

Open
6 tasks
thiyyakat opened this issue Dec 27, 2024 · 0 comments
Open
6 tasks

MCM integration tests failing due to missing label on Machine object #960

thiyyakat opened this issue Dec 27, 2024 · 0 comments
Assignees
@aaronfern @thiyyakat
Labels
area/testing Testing related kind/bug Bug kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@thiyyakat
Copy link
Contributor

thiyyakat commented Dec 27, 2024 •
edited
Loading

How to categorize this issue?

/area testing
/kind enhancement
/priority 3

What happened:
The node-agent-authorizer authenticating webhook in gardener-resource-manager introduced by PR gardener/gardener#10535, specifically https://github.com/gardener/gardener/blob/3d9c6bbc9557f36ad346efae7073b7184745420f/pkg/resourcemanager/webhook/nodeagentauthorizer/authorizer.go#L204, requires label worker.gardener.cloud/gardener-node-agent-secret-name to be set correctly on the machine object. However, the machine objects created as a part of the integration tests for MCM providers, do not have this label, preventing the node from being created and causing tests to fail across all providers.

PRs as a part of the fix:

  • MCM
  • mcm-provider-aws
  • mcm-provider-azure
  • mcm-provider-gcp
  • mcm-provider-openstack
  • mcm-provider-alicloud
@thiyyakat thiyyakat added the kind/bug Bug label Dec 27, 2024
@thiyyakat thiyyakat self-assigned this Dec 27, 2024
@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronfern aaronfern

@thiyyakat thiyyakat

Labels
area/testing Testing related kind/bug Bug kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gardener-robot @aaronfern @thiyyakat