Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSD metric using precision threshold #866

Open
gw265981 opened this issue Nov 14, 2024 · 0 comments
Open

KSD metric using precision threshold #866

gw265981 opened this issue Nov 14, 2024 · 0 comments

Comments

@gw265981
Copy link
Contributor

What's the issue?

The MMD metric has been changed from using a precision threshold to just setting the floor to 0 in order to deal with precision issues (#862).

The KSD metric is for now unchanged because: 1) it hasn't been observed to suffer from the same issue in practice; 2) it could theoretically be negative if $p(x)$ and/or $\lambda$ are very large.

If we are confident that the KSD metric should always be non-negative or if we encounter similar precision issues, we can enact the same change for KSD in the future.

@gw265981 gw265981 added the new Something yet to be discussed by development team label Nov 14, 2024
@tp832944 tp832944 removed the new Something yet to be discussed by development team label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants