Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to load gmfs in real-life calculations #864

Open
ptormene opened this issue Jun 5, 2024 · 2 comments
Open

Impossible to load gmfs in real-life calculations #864

ptormene opened this issue Jun 5, 2024 · 2 comments
Assignees
Labels

Comments

@ptormene
Copy link
Member

ptormene commented Jun 5, 2024

The current way we are displaying the options to plot the gmfs doesn’t work when having multiple gmfs and multiple gmpes (a reasonable calculation, not a demo for a workshop). The window can not be re-seized and it’s not possible to scroll down, therefore is not possible to plot any gmf.

An alternative will be to stored all gmfs per GMPE in a single file, and plot the first one. In that way, the user could choose only the GMPE and have all the possible simulations in the columns of the layer.

@ptormene ptormene added the bug label Jun 5, 2024
@ptormene ptormene self-assigned this Jun 5, 2024
@micheles
Copy link
Contributor

micheles commented Jun 5, 2024

My understanding is that the plot is useful for scenario computations (i.e. few gsims) and not for event based calculations, where there will be too many GMFs anyway, so it will be impossible to do it. Perhaps we should just raise an error? To be discussed with @CatalinaYepes

@CatalinaYepes
Copy link
Collaborator

Solving this bug is really important!

For scenarios, usually we do less than 1000 gmfs, and a few gmpes. This is reasonable, and an error should not be raised.

@micheles here is a proposal for scenario and eb calculations when loading gmfs in the plugin:

  1. The user selects the event or realization to show. This uses the branch_path from the realizations output, and by default we show the first one.

    1. For scenario calcs, this will have a few options (usually between 1 - 6).
    2. For eb calcs, the number of paths is usually large tens to thousands (depending on the model). In this case, when we have a number above something reasonable to handle with a drop-down menu (maybe 50?), we only provide then first 50 options, and include a message that says not loading others.
  2. The user select the IMT to use

  3. The generated attribute table should be per branch_path and per IMT, instead of per event. In this way we have layer called calc_type_gmfs_gsim_IMT, for example scenario_ParkerEtAl2020SInter_PGA. The attribute table should report the site_id and in each column the events associated to the gsim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants