Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing observation events #445

Closed
swalker2m opened this issue May 22, 2023 · 3 comments · May be fixed by #605
Closed

Missing observation events #445

swalker2m opened this issue May 22, 2023 · 3 comments · May be fixed by #605

Comments

@swalker2m
Copy link
Contributor

swalker2m commented May 22, 2023 •
edited
Loading

There is a table per science mode. An example is t_gmos_north_long_slit. Each references the observation with which it should be associated. @cquiroz reports that edits to those tables do not generate observation update events. Logically changing mode parameters is an observation edit. Perhaps we need to add a trigger on these tables (currently just t_gmos_north_long_slit and t_gmos_south_long_slit)?
@tpolecat
Copy link
Member

@cquiroz I wrote a test for this and it passes … can you still reproduce in Explore? Maybe it got fixed inadvertently.

@tpolecat tpolecat mentioned this issue Jul 26, 2023
Draft
@cquiroz
Copy link
Contributor

cquiroz commented Aug 1, 2023

The one case I remember is when editing the offsets we wouldn't see an event with the updated offsets to display.

I just tested it and it is now working as expected

@swalker2m
Copy link
Contributor Author

This seems to be working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: resolve 445? gemini-hlsw/lucuma-odb
3 participants
@tpolecat @cquiroz @swalker2m