-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Automatically detect remote style sheets #49
Comments
Hi @VladimirMikulic , It is actually possible but let me think about it. BTW, should we only allow |
Hi @gencer. Thank you very much for a fast reply. Instead of an array, you could maybe have parseRemoveStyleSheets as boolean. For the initial implementation, only |
Sounds good to me. Both |
Awesome! Thank you very much. |
This can be implemented. I believe i can parse html with regex and inlcude in the project however this is going to be harder on other template providers. I have two options here. A) only support html for now and provide option for this Im evaluating these options now. |
@gencer that's some good news. Let me know what you've decided to do. In my opinion, the unified parser would be really cool to have (as a config option maybe). |
@VladimirMikulic Can you test this version, please? Before installing this one, please remove all Currently this will try to load from HTML only. There is a new configuration parameter called "html-css-class-completion.searchRemoteGlobPattern": {
"type": "string",
"default": "**/*.{svelte,latte,php,html,twig}",
"description": "A glob pattern that includes html code which will be parsed if its contains Remote CSS"
}, But its currently only supported on Awaiting your feedback. v1.6.0 |
@gencer this is AWESOME! I've just tried it out and guess what? I'll never have to memorize framework classes again :) There is one bug/feature that I've encountered. Let's say I include Bulma in my document and I cache the classes, it works, no problem. Then, I realize that the project requires Bootstrap and I replace the Bulma CDN href with Bootstrap's and cache the classes again. This time it suggests Bulma classes as well as Bootstrap classes, although I use only Bootstrap and I removed Bulma. I.E. the cache is not invalidated. It's not a top priority bug, though. Anyway, thank you very much on this, I'll be using v1.6.0 from now on! |
@VladimirMikulic Glad it did worked! 🎉 Well, i will also make sure cache gets invalidated after such changes. I will not publish this version yet due to cache invalidation. You can freely use this version. I will update here when i got more info about this bug. |
@VladimirMikulic Can you test this version to see re-cache works without using old remote stylesheet like you mentioned earlier. |
Please also note that, You have to explicitly set this within your settings for this version:
Then restart / install |
Hi @gencer. Thank you for coming back to me. |
Hmm. Weird. Lets try empty the folder then. Try this one: |
This one is no go as well. For example, let's say I cache Bulma classes and it does work fine, but if I delete Bulma and replace it with Bootstrap it won't fetch new classes. It still suggests Bulma classes. |
But previously, bootstrap and bulma both was suggested right? This time only old one. It's getting weirder. I will install a virtual machine and try there with few templates. Thank you so much for taking time to test them for me. Stay safe! |
That's correct. Previously, they were both suggested. |
Thanks @VladimirMikulic! I will try to debug this one to make sure it get refreshed when re-cached. In fact im planning to add this to incremental building. This means when you hit CTRL+S or just save, it will do the update for you. I will update here when i got something. |
CTRL+S would be really amazing workflow. Thank you very much on the effort that you've put into this extension! |
As the title suggests, I would like that this extension can suggest classes in a file that is referencing a remote style sheet without requiring me to add it to the
html-css-class-completion.remoteStyleSheets
property.Would that be possible? Thanks.
The text was updated successfully, but these errors were encountered: