Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto caching only occurs when I save an SCSS file #70

Open
LeeBuckle opened this issue Jul 6, 2021 · 3 comments
Open

Auto caching only occurs when I save an SCSS file #70

LeeBuckle opened this issue Jul 6, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@LeeBuckle
Copy link

LeeBuckle commented Jul 6, 2021

Version: 1.7.8

I thought the plugin wasn't automatically caching but I noticed it only seems to work one way. i.e. saving a css/scss file, those classes get cached.

• Create new class in SCSS file then save, the new class will be suggested in JS or JSX file.

• Create new class in JSX file then save, cache isn't automatic and clicking lightening bolt required.

• Create new class in JS file (javascript and javascriptreact) and save, no caching at all, not even manual.

Is it possible to trigger automatic cache when a JSX file is saved?
Additionally, can the plugin be made to cache normal JS files, or even just those with language mode javascriptreact? I tried adding 'js' to the glob pattern but that didn't seem to work.

Cheers 😁

@LeeBuckle LeeBuckle changed the title Auto caching only works occurs when I save an SCSS file Auto caching only occurs when I save an SCSS file Jul 6, 2021
@gencer
Copy link
Owner

gencer commented Jul 7, 2021

Hey @LeeBuckle

Yes, Auto caching mechanism is only for Stylesheets not for other languages. We may do this in the future but there are still other open issues in my backlog. I am thinking to handle all of this issues including this one hopefully in 1-2 weeks. I was very busy with my own job and a bit lost on open-source projects.

Will work on this for sure but no promises about JS/X TS/X files because right now, I have no idea how this will impact the overall performance. But kinda doable...

Let me know if you have any other thoughts on this issue here.

@gencer gencer added the enhancement New feature or request label Jul 7, 2021
@LeeBuckle
Copy link
Author

No worries, just glad to know that you might be able to add the functionality.

If it happens to be expensive, maybe it could be added with a toggle in the options? That way it's up to the user and can easily be switched off if it causes them any trouble.

@gencer
Copy link
Owner

gencer commented Jul 14, 2021

If it happens to be expensive, maybe it could be added with a toggle in the options? That way it's up to the user and can easily be switched off if it causes them any trouble.

That would be much better. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants