Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerise tests & better documentation #142

Open
jufemaiz opened this issue Dec 21, 2018 · 1 comment
Open

Dockerise tests & better documentation #142

jufemaiz opened this issue Dec 21, 2018 · 1 comment

Comments

@jufemaiz
Copy link

Currently trying to make a PR to deal with Postgresql failures due to Arel SQL not providing an alias to :distance and thus returning no values (otherwise I'll just go and use the geocoder gem instead).

Is it possible to adopt Docker as a better solution for testing against multiple databases? This way anyone can more easily contribute without needing to install on their host OS the various databases (and versions of those databases).

Further, it would be good to then amend the README.md to cover off on this.

@mnoack
Copy link
Member

mnoack commented Dec 22, 2018

I'm a "passive" maintainer @jufemaiz - So I generally accepted any common sense pull request.

However I'm a bit busy now so I can't really review PRs, etc. I'm open to adding people to the project though if you want to help maintain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants