Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the binder_context, when there is function expression in the projection's target_list #1130

Closed
1 of 2 tasks
xzdandy opened this issue Sep 15, 2023 · 4 comments · Fixed by #1136
Closed
1 of 2 tasks
Assignees
Labels
Bug 🐞 EVA is not working as expected Feature Request ✨ New feature or request
Milestone

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 15, 2023

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

Right now, the binder_context is not getting updated for the function expression in the projection's target_list. So the following query will not work:

SELECT HomeSaleForecast(3) ORDER BY price;

CREATE TABLE AS SELECT HomeSaleForecast(3) FROM postgres.home_sale;

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@xzdandy xzdandy added the Feature Request ✨ New feature or request label Sep 15, 2023
@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 15, 2023

This will resolves the #1119

@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 17, 2023

5 long integration test failed. circle ci

FAILED test/integration_tests/long/test_select_executor.py::SelectExecutorTest::test_sort_on_nonprojected_column - evadb.executor.executor_utils.ExecutorError: ['myvideo.id']
FAILED test/integration_tests/long/test_similarity.py::SimilarityTests::test_end_to_end_index_scan_should_work_correctly_on_image_dataset - evadb.executor.executor_utils.ExecutorError: ['testsimilarityimagedataset.data']
FAILED test/integration_tests/long/test_similarity.py::SimilarityTests::test_should_do_vector_index_scan - AssertionError: False is not true
FAILED test/integration_tests/long/test_single_document_similarity.py::SingleDocumentSimilarityTests::test_single_pdf_should_work - AssertionError: False is not true
FAILED test/integration_tests/long/interfaces/relational/test_relational_api.py::RelationalAPI::test_create_index - evadb.executor.executor_utils.ExecutorError: ['meme_images.data']

@xzdandy xzdandy reopened this Sep 17, 2023
@xzdandy xzdandy added the Bug 🐞 EVA is not working as expected label Sep 17, 2023
@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 17, 2023

@gaurav274 A gentle ping.

@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 17, 2023

Investigating in #1147

@xzdandy xzdandy closed this as completed Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 EVA is not working as expected Feature Request ✨ New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants