Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if ioredis can be used as client #14

Open
dlebech opened this issue Feb 22, 2017 · 3 comments
Open

Investigate if ioredis can be used as client #14

dlebech opened this issue Feb 22, 2017 · 3 comments

Comments

@dlebech
Copy link
Contributor

dlebech commented Feb 22, 2017

Would it be possible to remove the client restriction here and either:

  1. Allow everything, thereby putting responsibility on the library user (This would allow mock objects)
  2. Add specific support for ioredis

I'm leaning towards 1 and then explicit stating in the documentation that redis is officially supported but other libraries can (possibly) be used to.

@stefanosala
Copy link
Contributor

I'm for 1. too, but we could at least check if the methods we need are in the passed client object and if they return promises.

@jeffmcaffer
Copy link

#1 would work for me as well.

@dlebech
Copy link
Contributor Author

dlebech commented Feb 28, 2017

@stefanosala @jeffmcaffer I've now tested the current suite with ioredis and there are 8 failing tests. It's possible it's something minor, but at least it's not just a matter of removing the client restriction without any further changes. I will leave this open for now, but I don't think I will have time in the near-future to deep dive into this and make it work for both clients.

However, I will still remove the client restriction so a mock object can be passed and leave responsibilty to the developer :-) This change is coming up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants