Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PII Scrubbing usernames from paths for Attachments / Minidumps not working #4368

Open
gid-sentry opened this issue Dec 10, 2024 · 3 comments
Assignees

Comments

@gid-sentry
Copy link

Scrubbing seems to work for both attachment and event field for native crash events sent to /minidump endpoint via curl command.

Scrubbing does not work for "mannually" constructed event. Example:

void SendEventToSenty(const std::string& minidumpPath)
{
    sentry_options_t* options = sentry_options_new();
    sentry_options_set_dsn(options, "DSN");
    sentry_options_set_database_path(options, "c:\\temp\\sentry-db");
    sentry_options_set_release(options, "My_Minidump");
    sentry_options_set_debug(options, 1);
    
    sentry_options_add_attachment(options, minidumpPath.c_str());
    sentry_options_add_attachment(options,"c:\\temp\\logfile.txt");
   
    gMinidumpPath = new std::string(minidumpPath);
    sentry_init(options);

    sentry_value_t event = sentry_value_new_message_event(
        SENTRY_LEVEL_ERROR,
        "pii-test2",
        "PII test2"
    );
   
    sentry_capture_event(event);
    sentry_close();
}

Example links in Customer Case

[#4351 fix(pii): Fix scrubbing user paths in minidump debug modules](#4351)

did not fix it unfortunately

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 10, 2024
@jjbayer
Copy link
Member

jjbayer commented Dec 12, 2024

  • PII scrubbing in minidumps had a bug that prevented user paths from being scrubbed, that should be fixed by fix(pii): Fix scrubbing user paths in minidump debug modules #4351.
  • Unlike what the docs imply, we do not scrub attachments other than minidumps. I will discuss with the team whether we can enable scrubbing for any attachment type, at least as a beta.
  • Attaching the minidump via add_attachment does not work because it will be treated as a regular attachment with attachment type event.attachment (see above). Minidump attachments require attachment type event.minidump.

I will keep this issue open because we need to at least improve our docs around this topic.

@jjbayer
Copy link
Member

jjbayer commented Dec 19, 2024

Query to surface PII rules with $attachments.'some_file': https://redash.getsentry.net/queries/7999/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants