Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default mode for OnUnhandledRejection integration #12074

Open
alexeyr-ci opened this issue Dec 9, 2024 · 1 comment
Open

Wrong default mode for OnUnhandledRejection integration #12074

alexeyr-ci opened this issue Dec 9, 2024 · 1 comment
Labels
Platform: JavaScript SDKs Type: Content Waiting for: Support

Comments

@alexeyr-ci
Copy link

SDK

JavaScript SDK

Description

https://docs.sentry.io/platforms/javascript/guides/fastify/configuration/integrations/unhandledrejection/ says the mode option

Defaults to none.

Same for https://docs.sentry.io/platforms/javascript/guides/nextjs/configuration/integrations/unhandledrejection/ and probably other JS frameworks. This confused me: why is this integration on by default if it doesn't send any warnings?

But according to https://github.com/getsentry/sentry-javascript/blob/6331d7ced7373e3f351ffacb71af54392c19acda/packages/node/src/integrations/onunhandledrejection.ts#L18, it actually defaults to warn, which makes more sense.

Suggested Solution

Update the default mode in the documentation.
@getsantry
Copy link
Contributor

getsantry bot commented Dec 9, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 3 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform: JavaScript SDKs Type: Content Waiting for: Support
Projects
GitHub Issues with 👀 3
Status: Waiting for: Support
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexeyr-ci