Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql): Document useOperationNameForRootSpan #12124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(graphql): Document useOperationNameForRootSpan #12124

wants to merge 2 commits into from
+12 −0

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Dec 13, 2024

DESCRIBE YOUR PR

docs for getsentry/sentry-javascript#13248

closes #12080

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@s1gr1d s1gr1d requested a review from AbhiPrasad December 13, 2024 10:22
@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 2:50pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 2:50pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 2:50pm

@s1gr1d s1gr1d requested review from mydea and coolguyzone December 13, 2024 10:22
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

coolguyzone
coolguyzone approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolguyzone coolguyzone coolguyzone approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document useOperationNameForRootSpan for graphqlIntegration
4 participants
@s1gr1d @mydea @AbhiPrasad @coolguyzone