Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to filter debug-files #277

Open
farfromrefug opened this issue Oct 10, 2024 · 9 comments
Open

Option to filter debug-files #277

farfromrefug opened this issue Oct 10, 2024 · 9 comments

Comments

@farfromrefug
Copy link

I use the cli through the fastlane plugin for iOS https://github.com/getsentry/sentry-fastlane-plugin.
when i do sentry_debug_files_upload:

sentry_debug_files_upload(
      url: ENV["SENTRY_URL"],
      org_slug: ENV["SENTRY_ORG"],
      project_slug: ENV["SENTRY_PROJECT"],
      wait: true,
      derived_data: false,
      include_sources: false,
      no_unwind: true,
      no_sources: true,
      upload_symbol_maps: true
    )

It detects a lot of debug files, some i want but also a lot i dont want for an iOS project on Macos, like .node files, files like ffi_c.bundle, libswiftos.dylib, sentry-cli-Darwin-universal, sentry-cli-Linux-x86_64, ....

It adds a lot of upload time, and server storage for nothing.
A simple solution would be a filter parameter. The ideal thing would be for it to support an "array" of name or glob

@kahest
Copy link
Member

kahest commented Oct 10, 2024

transferring this to https://github.com/getsentry/sentry-fastlane-plugin - we should discuss there what we can do ootb to improve this and feed back to sentry-cli for adaptations if needed

@kahest kahest transferred this issue from getsentry/sentry-cli Oct 10, 2024
@philipphofmann
Copy link
Member

When looking at the upload command of sentry-cli there isn't currently a way to filter debug files to upload. I think we should first add this functionality to sentry-cli and then a parameter here. @szokeasaurusrex, do you think it's reasonable to add this to sentry-cli?

@szokeasaurusrex
Copy link
Member

@philipphofmann that is correct, what I wanted to check first in the Fastlane plugin is whether perhaps we should be passing a more specific path to Sentry CLI. As in, maybe the files @farfromrefug is referring to are in a different directory which we should not be searching for debug files. If this is the case, then the requested filtering feature may not even be needed. Since the plugin passes the path to Sentry CLI, we could change this in the plugin.

If these files are in the same path as the debug symbols, then filtering is needed, and in that case, I agree that we should first implement the filtering in Sentry CLI.

@kahest kahest moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Oct 23, 2024
@kahest kahest moved this from Backlog to Needs More Information in Mobile & Cross Platform SDK Oct 23, 2024
@kahest
Copy link
Member

kahest commented Oct 23, 2024

@farfromrefug can you provide more information on how you use the fastlane-plugin, which folders do you provide?

@farfromrefug
Copy link
Author

@kahest i dont provide a folder i let the plugin find them. I use it as i show up above. in my context the xcode project is in platforms/ios
And it is an npm project so there is a node_modules folder (which could be where it finds many of files it reports)

@kahest
Copy link
Member

kahest commented Oct 23, 2024

@farfromrefug ah I see, thanks for clarifying - so you use it in conjunction with NativeScript I presume? We'll need to take a look at what the project folder structure looks like in that case and why/how the plugin picks up unwanted folders

@kahest kahest moved this from Needs More Information to Needs Discussion in Mobile & Cross Platform SDK Oct 23, 2024
@farfromrefug
Copy link
Author

@kahest indeed i do it with Nativescript. Here is a sample project https://github.com/Akylas/conty
Please let me know how i can help. Having first class fastlane support is really important for us

@kahest
Copy link
Member

kahest commented Oct 23, 2024

@farfromrefug thanks for the sample, that's helpful 🙏 I can't give an ETA, but if it's a smallish change, we might be able to squeeze it in

@brustolin brustolin moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Oct 30, 2024
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Backlog
Development

No branches or pull requests

4 participants