VSIX icons look strange

[drewnoakes]

Do you want to request a feature or report a bug?

Bug.

What is the current behavior?

In VS2017 with a dark theme enabled, the VSIX icons look like this:

Some of them look particularly bad, such as 'clone', 'manage remotes' and 'file history'.

It could be that VS attempts to darken them automatically to match the dark theme.

Environment you encounter the issue:

• GitExtensions version: 3.0 master from a few weeks ago
• OS version: Windows 10, latest updates

Did this work in previous version of GitExtensions (which)?

I don't know.

[gerhardol]

We could add icons where missing too (like diff, patch).
The icons look good in the light theme.
Some of the new icons look great in GE and in the light theme but worse in the dark theme (and gitextensions/gitextensions#5390 aligns more icons).

[RussKie]

This isn't particularly a high priority issue

…

On Tue, Sep 4, 2018, 7:26 AM Gerhard Olsson ***@***.***> wrote: We could add icons where missing too (like diff, patch). The icons look good in the light theme. Some of the new icons look great in GE and in the light theme but worse in the dark theme (and gitextensions/gitextensions#5390 <gitextensions/gitextensions#5390> aligns more icons). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/gitextensions/gitextensions/issues/5391#issuecomment-418194843>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXgd3APEV23yOF-BftGgzkBJYFactks5uXZ5xgaJpZM4WYDLc> .

[drewnoakes]

@dpoeschl happened to mention today that VS uses a specially coloured pixel in a corner to disable this behaviour. It might be cyan (EDIT: it's RGBA #00FFFF01), and it might be in the top left right corner.

EDIT here are some docs about the colour inversion in VS, but they don't mention the method of disabling such inversion:

https://docs.microsoft.com/en-us/visualstudio/extensibility/ux-guidelines/images-and-icons-for-visual-studio?view=vs-2017

[RussKie]

Your move to MS is already starting to pay off 😁

…

On Fri, Sep 28, 2018, 7:00 AM Drew Noakes ***@***.***> wrote: @dpoeschl <https://github.com/dpoeschl> happened to mention today that VS uses a specially coloured pixel in a corner to disable this behaviour. It might be cyan, and it might be in the top left corner. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/gitextensions/gitextensions/issues/5391#issuecomment-425241632>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXnAyG1X-5FhGI_PrGXAVfeM1GvQBks5ufTyAgaJpZM4WYDLc> .

[dpoeschl]

@drewnoakes It's not an official doc, but this explains it: https://stackoverflow.com/a/38263209

[drewnoakes]

@dpoeschl thanks a lot!

[drewnoakes]

There's also a AllowColorInversion attribute described here, though I'm not sure it's relevant to how we currently provide images: https://docs.microsoft.com/en-gb/visualstudio/extensibility/image-service-and-catalog?view=vs-2017