Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitExtensionsVSIX.Git.GitCommands.RunGit accesses ExitCode before WaitForExit #3

Open
mstv opened this issue Jul 5, 2020 · 0 comments
Open

GitExtensionsVSIX.Git.GitCommands.RunGit accesses ExitCode before WaitForExit #3

mstv opened this issue Jul 5, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@mstv
Copy link
Member

mstv commented Jul 5, 2020

Current behaviour

GitExtensionsVSIX.Git.GitCommands.RunGit accesses Process.ExitCode before calling Process.WaitForExit.
I expect Process.ExitCode to throw an InvalidOperationException.

(RunGit is called by GetCurrentBranch only.)

Expected behaviour

Access ExitCode after the process has exited.

Did this work in previous version of GitExtensions

don't know

Environment

GE 3.4.2
@RussKie RussKie transferred this issue from gitextensions/gitextensions Jul 7, 2020
@RussKie RussKie added the bug Something isn't working label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RussKie @mstv