Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[engine] 엔진 lint/prettier 적용 #662

Open
BeA-Pro opened this issue Aug 22, 2024 · 3 comments
Open

[engine] 엔진 lint/prettier 적용 #662

BeA-Pro opened this issue Aug 22, 2024 · 3 comments
Assignees
@choisohyun
Labels
🔍 analysis engine

Comments

@BeA-Pro
Copy link
Contributor

BeA-Pro commented Aug 22, 2024

현재 엔진 패키지에 lint/prettier가 적용되어 있지 않습니다.
시간되시는 분은 적용시켜보면 좋을 것 같아요!
@BeA-Pro BeA-Pro added this to the v0.7.1 milestone Aug 22, 2024
@seungineer
Copy link
Member

lint/prettier는 적용되어 있는데, 규칙과 코드가 안 맞을 경우 error를 표시하지 않네요.. 🤔

lint/prettier에 맞게 auto fix되도록 로컬 IDE를 설정해두니 엔진 패키지에서도 규칙에 맞게 고치긴 합니다 🤔🤔🤔

@BeA-Pro
Copy link
Contributor Author

BeA-Pro commented Aug 29, 2024

피드백 감사합니다!

@choisohyun choisohyun modified the milestones: v0.7.1, v0.7.2 Aug 29, 2024
@choisohyun choisohyun self-assigned this Sep 11, 2024
@choisohyun choisohyun mentioned this issue Sep 11, 2024
Closed
@choisohyun
Copy link
Contributor

(참고댓글 남깁니다) 논의 후 적용이 필요합니다 #722

@choisohyun choisohyun removed this from the v0.7.2 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@choisohyun choisohyun

Labels
🔍 analysis engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[all] lint/prettier husky, lint-staged 적용 githru/githru-vscode-ext
3 participants
@choisohyun @seungineer @BeA-Pro