Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_group_lasso issues #349

Open
pavanramkumar opened this issue Nov 3, 2019 · 0 comments
Open

test_group_lasso issues #349

pavanramkumar opened this issue Nov 3, 2019 · 0 comments
Labels

Comments

@pavanramkumar
Copy link
Collaborator

A couple of issues:

  • The assertion introduced in this commit which tests that at least one group must be all zeros seems not guaranteed to pass. In practice I've seen this fail very rarely in unrelated scenarios. It may be likely to fail in large n, small p regimes. Can we understand the rationale behind this assertion?

  • One reason it potentially fails stochastically is that we don't control the random state for sampling the parameters:

# sample random coefficients
beta0 = np.random.rand()
beta = np.random.normal(0.0, 1.0, n_features)
beta[groups == 2] = 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant