forked from vela-mills/movies-application
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Code_review.txt
51 lines (28 loc) · 1.32 KB
/
Code_review.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
Meeting date : 09/18/2019
Attendees : Justin Reich and Gloria Laura Vela
Expected modification
Implement a module to handle the DOM manipulation -- Complete & ongoing
Implement a module to handle the movie-api -- Completed
Add a notification at the bottom of the screen for non-destructive actions
Add a pop-up for destructive actions Delete and Update -- Delete completed & Update is WIP
Modify documentation to describe actions -- ongoing
Refactor to import only instead of require and import -- Completed
Modify index.js to handle high level -- Completed
The functions should use verbs to demonstrate actions -- Completed
Include the Init() function to initialize the variables -- Completed
-- Meeting date: 10/02/2019
Attendees : Justin Reich and Gloria Laura Vela
Expected modifications
Include comments for the modules and functions
Extra---
Reorganize the css
Add modals (Update, Delete and checkboxes)
Meeting date: 10/07/2019
Attendees : Justin Reich and Gloria Laura Vela
Expected modifications
-- Block comments for the module or the functions
-- line comments for the rest
-- No space between the comment and the code
-- Make it mobile responsive
-- Add a notification at the bottom of the screen for non-destructive actions
-- Add a pop-up for destructive actions Delete and Update -- Delete completed & Update is WIP