Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline search for solution process #18500

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

cconard96
Copy link
Contributor

@cconard96 cconard96 commented Dec 7, 2024

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

When using object locks, there was an opportunity for a technician to lose the lock on a ticket when searching for a solution because the process redirects out of the ticket for the solution search/selection part.

This PR moves the solution selection to a modal and allows adding the article content directly to the solution content without any redirects/page reloads.

Fixes #18490

src/KnowbaseItem.php Show resolved Hide resolved
src/Glpi/Controller/KBController.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne requested a review from orthagh December 10, 2024 09:15
@cconard96 cconard96 marked this pull request as draft December 10, 2024 22:51
@orthagh
Copy link
Contributor

orthagh commented Dec 13, 2024

Regarding UX.
I like the idea of getting the kb directly displayed in a modal and it's a good starting point.
But the view of the content of an article is bad currently.
We move to a full layout of GLPI if we click on an article's title, and we don't have anymore a "use as solution" button.
image

Also, this part is very badly displayed:
image

I think we should probably remove it completely in the modal

@cconard96
Copy link
Contributor Author

There are a few things that aren't handled yet like linking the KB article in addition to just copying the content, pagination, etc.

This work is going to need be more complex so I put it to draft.

@cconard96
Copy link
Contributor Author

It is rough, but here is a replacement UI proposal for searching solutions:
Selection_380

I pushed commits that add this and it should be functional. The only main thing missing is pagination.

When you click the button to search for a solution, it presents you with a list of matching articles rather than the table that was there previously. Each result has two buttons; A button to use it as the solution and a button to preview the article. If you preview an article, the results are hidden and the "full" form of the article is shown in its place in the modal. A button at the top of the preview lets you go back to the results. Searching from inside this modal refreshes the results via AJAX.

@orthagh
Copy link
Contributor

orthagh commented Dec 16, 2024

It should be good like this.

@cconard96 cconard96 marked this pull request as ready for review January 4, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When searching for a solution, the ticket loses the Lock status
3 participants