Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projected image does not convert #13

Closed
Tim-Evans-Seequent opened this issue Oct 11, 2024 · 0 comments · Fixed by #14
Closed

Projected image does not convert #13

Tim-Evans-Seequent opened this issue Oct 11, 2024 · 0 comments · Fixed by #14
Assignees
Labels
bug Something isn't working omf1 Issues related to the OMF1 converter

Comments

@Tim-Evans-Seequent
Copy link
Contributor

Tim-Evans-Seequent commented Oct 11, 2024

plane_surface.omf.gz fails to convert from OMF1 with these errors:

  • 'Orient2::u' must be a unit vector but [0.0026686676037428235, 0.0003693918434559309, 0.0] length is 0.0026941, inside 'test'
  • 'Orient2::v' must be a unit vector but [-0.0002940052925535278, 0.003057655042556713, 0.0] length is 0.0030717, inside 'test'
  • 'Orient2' vectors are not orthogonal: [0.0026686676037428235, 0.0003693918434559309, 0.0] [-0.0002940052925535278, 0.003057655042556713, 0.0], inside 'test'

The file is exported from Leapfrog. There are two issues here:

  1. The U and V vectors are very short, likely the size of one pixel, and will need to be normalised.
  2. The U and V vectors aren't orthogonal, and probably shouldn't be required to be.

Change the code here to allow skewed images, and to correctly normalise the U and V vectors when converting OMF1 images.

@Tim-Evans-Seequent Tim-Evans-Seequent added bug Something isn't working omf1 Issues related to the OMF1 converter labels Oct 11, 2024
@Tim-Evans-Seequent Tim-Evans-Seequent self-assigned this Oct 11, 2024
Tim-Evans-Seequent pushed a commit that referenced this issue Oct 21, 2024
@Tim-Evans-Seequent Tim-Evans-Seequent linked a pull request Oct 21, 2024 that will close this issue
Tim-Evans-Seequent added a commit that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working omf1 Issues related to the OMF1 converter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant