Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with latest git snapshot #1791

Open
opoplawski opened this issue Mar 23, 2024 · 2 comments
Open

Build failure with latest git snapshot #1791

opoplawski opened this issue Mar 23, 2024 · 2 comments
Labels
ON HOLD : Please Answer question GDL Team is Waiting for external input

Comments

@opoplawski
Copy link
Contributor

Trying to build the latest weekly snapshot release on Fedora Rawhide with python 3.12.2 I'm getting:

/home/orion/fedora/gdl/gdl-unstable-41ca272/src/pythongdl.cpp:287:61: error: ‘SigFPEHandler’ was not declared in this scope; did you mean ‘oldSigFPEHandler’?
  287 |   PyOS_sighandler_t oldSigFPEHandler   = PyOS_setsig(SIGFPE,SigFPEHandler);
      |                                                             ^~~~~~~~~~~~~
      |                                                             oldSigFPEHandler
/home/orion/fedora/gdl/gdl-unstable-41ca272/src/pythongdl.cpp: In function ‘PyObject* GDL_script(PyObject*, PyObject*, PyObject*)’:
/home/orion/fedora/gdl/gdl-unstable-41ca272/src/pythongdl.cpp:467:63: error: ‘SigFPEHandler’ was not declared in this scope; did you mean ‘oldSigFPEHandler’?
  467 |     PyOS_sighandler_t oldSigFPEHandler   = PyOS_setsig(SIGFPE,SigFPEHandler);
      |                                                               ^~~~~~~~~~~~~
      |                                                               oldSigFPEHandler
@GillesDuvert
Copy link
Contributor

@opoplawski thanks, strange that this was not checked by our GH builds. SigFPEHandler was removed recently in favor of another method. Probably harmless to remove any reference to it in the pythongdl.cpp code.

@GillesDuvert
Copy link
Contributor

removed lines referring to SigFPEHandler in pythongdl.cpp. Hope you'll have better luck this time. Tanks for the report!

@GillesDuvert GillesDuvert added the ON HOLD : Please Answer question GDL Team is Waiting for external input label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ON HOLD : Please Answer question GDL Team is Waiting for external input
Projects
None yet
Development

No branches or pull requests

2 participants