Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding submatch (capture group) support. #3

Open
chris-garrett opened this issue May 1, 2021 · 2 comments
Open

Adding submatch (capture group) support. #3

chris-garrett opened this issue May 1, 2021 · 2 comments

Comments

@chris-garrett
Copy link

Hiya,

I have a PR up on the original repo to add capture group support (submatch) to strings. The function is called: regexFindSubmatch. I would love to see this in task if that is possible. I'm not sure what the process is for doing that. Should I also PR against this repo?

PR on masterminds is here:

Masterminds#298

A second branch which is up to date with this repo is here:

https://github.com/chris-garrett/slim-sprig/tree/add-find-submatches

Let me know what you think Andrey.

Thanks!

@andreynering
Copy link
Member

Hi @chris-garrett,

Once the PR is merged upstream just let me know so I can update this repo with upstream to automatically have that.

I woudn't add it here first, because if it happens to go to upstream with a different name or signature (for example), then we'll have a problem (at least it would be inconsistent).

@chris-garrett
Copy link
Author

sounds good ty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants