You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a PR up on the original repo to add capture group support (submatch) to strings. The function is called: regexFindSubmatch. I would love to see this in task if that is possible. I'm not sure what the process is for doing that. Should I also PR against this repo?
Once the PR is merged upstream just let me know so I can update this repo with upstream to automatically have that.
I woudn't add it here first, because if it happens to go to upstream with a different name or signature (for example), then we'll have a problem (at least it would be inconsistent).
Hiya,
I have a PR up on the original repo to add capture group support (submatch) to strings. The function is called: regexFindSubmatch. I would love to see this in task if that is possible. I'm not sure what the process is for doing that. Should I also PR against this repo?
PR on masterminds is here:
Masterminds#298
A second branch which is up to date with this repo is here:
https://github.com/chris-garrett/slim-sprig/tree/add-find-submatches
Let me know what you think Andrey.
Thanks!
The text was updated successfully, but these errors were encountered: