Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add splitArgs template function to allow to reliably get arguments of CLI_ARGS #1040

Closed
andreynering opened this issue Mar 7, 2023 · 4 comments · Fixed by #1059
Closed

Add splitArgs template function to allow to reliably get arguments of CLI_ARGS #1040

andreynering opened this issue Mar 7, 2023 · 4 comments · Fixed by #1059
Labels
good first issue Issues that are good for first-time contributors to pick up.

Comments

@andreynering
Copy link
Member

Idea came from: #327 (comment)

We should use the shell parser library to do that (mvdan/sh).

Reminder: Update documentation to mention this possibility.
@andreynering andreynering added enhancement good first issue Issues that are good for first-time contributors to pick up. labels Mar 7, 2023
@andreynering andreynering mentioned this issue Mar 7, 2023
Closed
@dhanusaputra
Copy link
Contributor

hi, may I help with this task? thanks

@pd93
Copy link
Member

pd93 commented Mar 10, 2023

hi, may I help with this task? thanks

Of course! Anyone is welcome to contribute. Please take a look at our contribution guide and feel free to open a PR if you get this working.

@dhanusaputra dhanusaputra mentioned this issue Mar 14, 2023
Merged
@gabyx
Copy link

gabyx commented Nov 14, 2023

This feature should be provided by Task itself in the form of .CLI_ARGUMENTS which is passed as []string.
It makes absolutely no sense to go over templating to then reextract the arguments.

@mpyw
Copy link

mpyw commented Apr 3, 2024 •
edited
Loading

I agree with that. The actual feature we've wanted is receiving arguments through "$@".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are good for first-time contributors to pick up.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add splitArgs template function dhanusaputra/task
5 participants
@gabyx @mpyw @andreynering @pd93 @dhanusaputra