Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude other "ignored" files. #1356

Merged
merged 3 commits into from
Oct 7, 2023
Merged

fix: exclude other "ignored" files. #1356

merged 3 commits into from
Oct 7, 2023

Conversation

butuzov
Copy link
Contributor

@butuzov butuzov commented Oct 1, 2023

Limits ignore files to exact 4 directories used to be ignored before ".git/.hg/node_modules/.task"

Usecase: setting up monitoring for the files that matches ignored directory, but not location inside of it. So for example, we I want (actual case I run into) to monitor "yaml" templates and test them on change, I can't use .github directory as it ignored by default because it matches .git.

limits ignore files to exact 4 directories mentioned before ".git/.hg/node_modules/.task"
@butuzov
Copy link
Contributor Author

butuzov commented Oct 1, 2023

Looks like test didn't run (so no main tests are running for PR tests) ?

@pd93
Copy link
Member

pd93 commented Oct 1, 2023

Looks like test didn't run (so no main tests are running for PR tests) ?

The watch tests are disabled in CI because they can be flaky. These are excluded using the build tags at the top of the watch_test.go file. See related commit: d6d51a2.

You can run task test:all to include these tests when running locally. On that note, these tests are currently failing because your new method is not exported and the test file is in a test package (task_test). I don't think we really want to export the method though, so perhaps we should change the package for watch_test.go to task.

watch.go Outdated Show resolved Hide resolved
Co-authored-by: Pete Davison <[email protected]>
@andreynering
Copy link
Member

Thanks @butuzov!

@andreynering andreynering merged commit 2f92f2a into go-task:main Oct 7, 2023
10 checks passed
andreynering added a commit that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants