Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial requires_strict setup #1370

Closed
wants to merge 2 commits into from
Closed

Conversation

mgale
Copy link

@mgale mgale commented Oct 10, 2023

This PR adds a new attribute called requires_strict which by default mimics the requires behaviour but will fail if the values are empty strings and provides an option called limit_values which can function like an enum:

  task-example:
    requires_strict:
      vars: [VAR_ONE, VAR_THREE, VAR_TWO]
      limit_values:
        VAR_TWO:
          - "foo"
          - "bar"
          - "two"
    cmds:
      - echo '{{.VAR_TWO}}'

Examples can be seen here: https://github.com/go-task/task/pull/1370/files#diff-62762ddb42701438813445ff0303d0f357cfe2d0d6f38969c45224befb143ea4

@mgale
Copy link
Author

mgale commented Dec 1, 2023

It has been over a month and a half since I created this PR and I haven't heard anything. I also tried reaching out on discord a few times and got no response. I am closing this PR, if this is something the community is interested in the future just reach out.

@mgale mgale closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant