Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.35.0 Regression: Source paths will always be returned as paths relative to the task directory #1529

Closed
danilobuerger opened this issue Mar 4, 2024 · 3 comments · Fixed by #1530

Comments

@danilobuerger
Copy link
Contributor

In https://taskfile.dev/usage/ it is specified that:

Source paths will always be returned as paths relative to the task directory

The following Taskfile worked in 3.33.1 but does not work in 3.35.0:

version: "3"

tasks:
  foo:
    cmds:
      - for: sources
        cmd: echo {{.ITEM}}
    sources:
      - "**/*.txt"
    method: none

With a file at 123/456/asd.txt the output for 3.33.1 was:

❯ task foo
task: [foo] echo 123/456/asd.txt
123/456/asd.txt
❯ cd 123 && task foo
task: [foo] echo 123/456/asd.txt
123/456/asd.txt

Now with 3.35.0 it is:

❯ task foo
task: [foo] echo 123/456/asd.txt
123/456/asd.txt
❯ cd 123 && task foo
task: [foo] echo 456/asd.txt
456/asd.txt
  • Task version: 3.35.0
  • Operating system: MacOS 14.3.1
  • Experiments enabled: No
@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Mar 4, 2024
@danilobuerger danilobuerger changed the title Source paths will always be returned as paths relative to the task directory 3.35.0 Regression: Source paths will always be returned as paths relative to the task directory Mar 4, 2024
@danilobuerger
Copy link
Contributor Author

@pd93 pd93 added type: bug Something not working as intended. and removed state: needs triage Waiting to be triaged by a maintainer. labels Mar 4, 2024
@pd93
Copy link
Member

pd93 commented Mar 4, 2024

@danilobuerger Thanks for reporting. #1530 should fix.

@danilobuerger
Copy link
Contributor Author

@pd93 Thanks Pete! Can confirm it works again with

Task version: v3.35.1-0.20240304111842-35ab37449adc

@pd93 pd93 closed this as completed in #1530 Mar 4, 2024
@pd93 pd93 removed the type: bug Something not working as intended. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants