Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish completions don't report aliases #1781

Closed
davinkevin opened this issue Sep 2, 2024 · 2 comments · Fixed by #1782
Closed

fish completions don't report aliases #1781

davinkevin opened this issue Sep 2, 2024 · 2 comments · Fixed by #1782
Assignees
Labels
area: completions Changes related to shell completions and scripts.

Comments

@davinkevin
Copy link

Hey team, 👋

A small feature request, because I use (and love) task for a long time, and I leverage completions a lot in my day to day work.

However, I'm not able to use aliases the same way, because they are ignored completly from completions script for my shell (that is fish).

See, with this following file:

version: 3

tasks:

  foo:
    aliases:
      - bar
    cmd: echo bar

  another: echo another

I have the following result:

image

The bar task, even if available, is totally ignored.

Can we do something about it?

@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Sep 2, 2024
@vmaerten
Copy link
Member

vmaerten commented Sep 2, 2024

Hey

Can you confirm you have the latest version of completion installed ? It seems it was been fixed (#1113 times ago)
I haven't fish so I cannot test it atm

@vmaerten vmaerten added state: awaiting response Waiting for issue author to respond. area: completions Changes related to shell completions and scripts. and removed state: needs triage Waiting to be triaged by a maintainer. labels Sep 2, 2024
@davinkevin
Copy link
Author

Hello 👋

image

All seems to be identical. Maybe a problem with the sed version used. In macOS, many people use the BSD, GNU or even an alternative version…

If I use explicitly the GNU version of sed, I have this:
image

And finally if I use the BSD version of sed:
image

And personally, I use sd instead of sed 😅. Would be so good to have those completion generated directly by task and not using system

If you want to test, it's easy: docker+fish, and I had the same result:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: completions Changes related to shell completions and scripts.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants