Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain preconditions broken in >= 3.39.x #1836

Closed
wburningham opened this issue Sep 24, 2024 · 2 comments
Closed

Certain preconditions broken in >= 3.39.x #1836

wburningham opened this issue Sep 24, 2024 · 2 comments
Labels
state: can't repro Not enough information was given to reproduce the issue described.

Comments

@wburningham
Copy link

Environment info:

  • Task version: 3.39.0
  • Operating system: OS: macOS 14.6.1 23G93 arm64
  • Experiments enabled: TASK_X_REMOTE_TASKFILES

Description:

Certain preconditions start failing in >= 3.39.0 that used to work in 3.38.0.

Steps to reproduce:

❯ cat taskfile.dist.yaml
---
version: 3

tasks:
  default:
    preconditions:
      - docker --version
    cmd: docker --version⏎                                                                                                         

❯ docker --version
Docker version 25.0.3, build 4debf41

Expected results

The task should execute like it does in v3.38.0

❯ go run github.com/go-task/task/v3/cmd/[email protected]
task: [default] docker --version
Docker version 25.0.3, build 4debf41

Actual results

The task fails in a precondition in version >= v3.39.0

❯ go run github.com/go-task/task/v3/cmd/[email protected]
task: `docker --version` failed
task: precondition not met
exit status 1

❯ go run github.com/go-task/task/v3/cmd/[email protected]
task: `docker --version` failed
task: precondition not met
exit status 1
@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Sep 24, 2024
@vmaerten
Copy link
Member

I cannot reproduced.
I tried with my linux but also with a Macbook M2. Can you reproduce in a CI (Github action ? Gitlab CI ?)

@vmaerten vmaerten added state: awaiting response Waiting for issue author to respond. state: can't repro Not enough information was given to reproduce the issue described. and removed state: needs triage Waiting to be triaged by a maintainer. labels Sep 28, 2024
@wburningham
Copy link
Author

Running go run github.com/go-task/task/v3/cmd/[email protected] works as expected so it seems like it has been fixed with the recent 3.40 release. This can be closed.

@task-bot task-bot removed the state: awaiting response Waiting for issue author to respond. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: can't repro Not enough information was given to reproduce the issue described.
Projects
None yet
Development

No branches or pull requests

3 participants