feat(fingreprinting): add .taskignore #1932
Conversation
|
Greetings, and thanks for a wonderful project! The reasoning behind this PR is as follows: DesignSince the project already heavily relies on glob semantics, aligning the same semantics in the Taskfile's
|
GeneTakavic24
force-pushed
the
taskignore
branch
from
9102660 to
bf471c7
Compare
| @@ -789,6 +789,37 @@ tasks: | |||
| - public/bundle.css | |||
| ``` | |||
|
|
|||
| It is also possible to exclude files from fingerprinting globally by creating `.taskignore` | |||
There was a problem hiding this comment.
nit: I would add "a" -- that is, change
[...] creating
.taskignorefile [...]
to
[...] creating a
.taskignorefile [...]
| @@ -0,0 +1 @@ | |||
| ./**/*.json | |||
There was a problem hiding this comment.
Suggest adding a comment line to make sure comments are correctly processed:
# ./dont_ignore.txt
There was a problem hiding this comment.
Also some blank lines to make sure trimming also works correctly.
|
|
||
| for _, line := range lines { | ||
| trimmed := strings.TrimSpace(line) | ||
| if trimmed != "" && !strings.HasPrefix(trimmed, "#") { |
There was a problem hiding this comment.
Users might expect that end-line comments (e.g., ./**/*.json # ignore pesky JSON files) are allowed, as they tend to be allowed in similar file formats.
There was a problem hiding this comment.
Looks pretty good to me.
If exclude supports negations, I would clarify in the docs and code whether negations are allowed in the .taskignore file (and unit test it).
I'm not sure whether they'd be supported, from looking at the code (I don't recall whether exclude supports them).
NB: I am not a maintainer or (at least not yet) even a contributor to the project!
Fixes #1753