Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic/nil for empty command in included taskfile #678

Closed
philpennock opened this issue Feb 25, 2022 · 3 comments
Closed

panic/nil for empty command in included taskfile #678

philpennock opened this issue Feb 25, 2022 · 3 comments

Comments

@philpennock
Copy link
Contributor

This issue is a mix of #338 and #612 -- an empty task causes a crash, but only if the empty task is in an included taskfile.

  • Task version: 3.11.0
    • Task version: v3.11.0 (h1:eCcCe1cKyta4YnGQYLo2FriPS9h7fFS8XBVW6QvWEV4=)
  • Operating System:
    • Ubuntu 20.04 LTS
    • task installed with go install github.com/go-task/task/v3/cmd/task@latest, Go 1.17.7

Example Taskfile showing the issue

  1. Taskfile.yaml:
    version: '3'
    includes:
      a: taskfile-inc.yaml
  2. taskfile-inc.yaml
    version: '3'
    tasks:
      bar:
$ task -l
panic: runtime error: invalid memory address or nil pointer dereference
[...]
@tylermmorton
Copy link
Contributor

Thank you for reporting this. I will see if I can add a fix and test coverage in my PR at #656.

@ghostsquad ghostsquad added the type: bug Something not working as intended. label May 16, 2022
@vmaerten
Copy link
Member

I've tested with v3.36.0
It's fixed now

@pd93
Copy link
Member

pd93 commented May 11, 2024

@vmaerten Thanks for checking!

@pd93 pd93 closed this as completed May 11, 2024
@pd93 pd93 removed the type: bug Something not working as intended. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants