Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: accepted as task key #911

Closed
Rots opened this issue Oct 27, 2022 · 2 comments
Closed

cmd: accepted as task key #911

Rots opened this issue Oct 27, 2022 · 2 comments

Comments

@Rots
Copy link

Rots commented Oct 27, 2022

As discussed in https://discord.com/channels/974121106208354339/1035111266005569567

With this input

version: '3'

tasks:
  hello-broken:
    cmd: echo 'Hello World from Task!'
    deps:
      - run-first
  hello-works:
    cmds: [echo 'Hello World from Task!']
    deps:
      - run-first
  run-first: echo "This as a dependency should run first"

Gives the following output:

$ task hello-works -v
task: "hello-works" started
task: "run-first" started
task: [run-first] echo "This as a dependency should run first"
This as a dependency should run first
task: "run-first" finished
task: [hello-works] echo 'Hello World from Task!'
Hello World from Task!
task: "hello-works" finished

We would expect the hello-broken to either fail with a message that cmd: is an unsupported key or to behave similarly to the above output.
Actual output:

$ task hello-broken -v
task: "hello-broken" started
task: [hello-broken] echo 'Hello World from Task!'
Hello World from Task!
task: "hello-broken" finished
  • Task version: 3.17.0
  • Operating System: Ubuntu
@pd93 pd93 added the type: bug Something not working as intended. label Oct 29, 2022
@tennox
Copy link

tennox commented Dec 24, 2023

I was also confused by this. Thought there is a nice short syntax for tasks with a single cmd (which would be my favorite), but then they just didn't do anything 😓

@pd93
Copy link
Member

pd93 commented Dec 24, 2023

Hi @tennox and @Rots. Looks like this was fixed in #1131 and we forgot to close this issue. This change was released in v3.26.0, so updating to any version newer than this should fix this issue.

@pd93 pd93 closed this as completed Dec 24, 2023
@pd93 pd93 removed the type: bug Something not working as intended. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants