From 068971e5eee322b993bcba9c38f7ea9362b04755 Mon Sep 17 00:00:00 2001 From: Gumar Minibaev Date: Fri, 8 Dec 2023 14:16:27 +0200 Subject: [PATCH 1/4] define different deploy strategy for jobservice --- templates/jobservice/jobservice-dpl.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/templates/jobservice/jobservice-dpl.yaml b/templates/jobservice/jobservice-dpl.yaml index e39e77e6e..4c0a45718 100644 --- a/templates/jobservice/jobservice-dpl.yaml +++ b/templates/jobservice/jobservice-dpl.yaml @@ -9,8 +9,9 @@ spec: replicas: {{ .Values.jobservice.replicas }} revisionHistoryLimit: {{ .Values.jobservice.revisionHistoryLimit }} strategy: - type: {{ .Values.updateStrategy.type }} - {{- if eq .Values.updateStrategy.type "Recreate" }} + {{- $strategyType := (.Values.jobservice.strategyType | default .Values.updateStrategy.type) }} + type: {{ $strategyType }} + {{- if eq $strategyType "Recreate" }} rollingUpdate: null {{- end }} selector: From 0023d0837fd6b5d21be216330fa0f2b337f66be9 Mon Sep 17 00:00:00 2001 From: Gumar Minibaev Date: Tue, 13 Aug 2024 13:41:37 +0200 Subject: [PATCH 2/4] Update values.yaml --- values.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/values.yaml b/values.yaml index 7e7490650..6065aba9c 100644 --- a/values.yaml +++ b/values.yaml @@ -633,6 +633,9 @@ jobservice: # mount the service account token automountServiceAccountToken: false replicas: 1 + # uncomment following lines to specify different updateStrategy for jobService + # updateStrategy: + # type: ReCreate revisionHistoryLimit: 10 # resources: # requests: From ded97c97e0e069d419587f734826677194fc167d Mon Sep 17 00:00:00 2001 From: Gumar Minibaev Date: Tue, 13 Aug 2024 13:46:19 +0200 Subject: [PATCH 3/4] Update README.md --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 91687ddaf..04cf67341 100644 --- a/README.md +++ b/README.md @@ -245,6 +245,8 @@ The following table lists the configurable parameters of the Harbor chart and th | `jobservice.image.tag` | Tag for jobservice image | `dev` | | `jobservice.replicas` | The replica count | `1` | | `jobservice.revisionHistoryLimit` | The revision history limit | `10` | + | +| `jobservice.updateStrategy.type` | The update strategy for jobservice deployment (if needs to be different from others): `RollingUpdate` or `Recreate`. Set it as `Recreate` when `RWM` for volumes isn't supported | same as general `updateStrategy.type`| | `jobservice.maxJobWorkers` | The max job workers | `10` | | `jobservice.jobLoggers` | The loggers for jobs: `file`, `database` or `stdout` | `[file]` | | `jobservice.loggerSweeperDuration` | The jobLogger sweeper duration in days (ignored if `jobLoggers` is set to `stdout`) | `14` | From 74875b2e8035187d543f216f16b13689d066632b Mon Sep 17 00:00:00 2001 From: Gumar Minibaev Date: Tue, 13 Aug 2024 13:53:36 +0200 Subject: [PATCH 4/4] Update README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 04cf67341..b2fa1f269 100644 --- a/README.md +++ b/README.md @@ -245,7 +245,6 @@ The following table lists the configurable parameters of the Harbor chart and th | `jobservice.image.tag` | Tag for jobservice image | `dev` | | `jobservice.replicas` | The replica count | `1` | | `jobservice.revisionHistoryLimit` | The revision history limit | `10` | - | | `jobservice.updateStrategy.type` | The update strategy for jobservice deployment (if needs to be different from others): `RollingUpdate` or `Recreate`. Set it as `Recreate` when `RWM` for volumes isn't supported | same as general `updateStrategy.type`| | `jobservice.maxJobWorkers` | The max job workers | `10` | | `jobservice.jobLoggers` | The loggers for jobs: `file`, `database` or `stdout` | `[file]` |