Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We can remove cert-manager this depend #1085

Open
lengrongfu opened this issue May 14, 2024 · 8 comments
Open

We can remove cert-manager this depend #1085

lengrongfu opened this issue May 14, 2024 · 8 comments

Comments

@lengrongfu
Copy link
Collaborator

Current harbor-operator depends on too many components, we hope can remove cert-manager this depend.

@lengrongfu
Copy link
Collaborator Author

My goal is to be as simple and easy to use as harbor-helm.

@Vad1mo
Copy link
Member

Vad1mo commented May 14, 2024

makes sense, however it shhould also still be self contained. How do you plan to make it work instead?

@lengrongfu
Copy link
Collaborator Author

Sorry, I haven't decided what needs to be done yet, but I'm considering taking this opportunity to improve the project. My goal is to enable users to deploy a harbor successfully without relying on other components.

@Vad1mo
Copy link
Member

Vad1mo commented May 15, 2024

Makes sense.

Before doing something that nobody want I would suggest you outline how the new solution will look and work for the user. Maybe a happy path installing and upgrading

This way we all get a clear foundation and understanding for a discussion. It becomes easy to see if this makes sense to be part of the operator or not.

@lengrongfu
Copy link
Collaborator Author

More precisely, I hope cert-manager to be optional.

There are two uses of cert-manager in the current project:

  1. Add the annotation cert-manager.io/inject-ca-from: harbor-operator-ns/serving-cert in Webhook to configure the HTTPS certificate.
  2. When the harbor components core, job, and register directly enable HTTPS communication, a certificate needs to be created, but this is optional.

So I want to change the first point to an optional operation and use a project similar to kube-webhook-certgen to generate https certificates.

@lengrongfu
Copy link
Collaborator Author

@Vad1mo what do you think?

@Vad1mo
Copy link
Member

Vad1mo commented Jun 12, 2024

Aren't you replacing one component that is popular and known with another component, less known or self - backed?

Don't get me wrong, if we can make cert-manager optional, especially because it is already often present, I am up for it.

What is not clear to me is the added benefit and gained simplicity or maintainability.

@Vad1mo
Copy link
Member

Vad1mo commented Jun 12, 2024

If it is difficult to explain in text you can join the community meeting and outline your idea, so we can discuss and make a decission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants