fix panics during Scans when there are no layers #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
force-pushed
the
no-panic-scans
branch
2 times, most recently
from
f1ec3c4 to
c8c6860
Compare
danielpacak
suggested changes
Oct 7, 2021
There was a problem hiding this comment.
Thank you for this PR @tariq1890 I left one suggestion.
Notice that we have to update CI validation workflow and probably migrate from Travis CI to GitHub Actions before we can merge your changes. I'll let you know to rebase your branch.
Signed-off-by: Tariq Ibrahim <[email protected]>
tariq1890
force-pushed
the
no-panic-scans
branch
from
c8c6860 to
f8b8f70
Compare
|
Thanks a lot @danielpacak . I've committed your suggestions |
danielpacak
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14