Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt google.golang.org/protobuf #228

Open
tlimoncelli opened this issue Dec 3, 2020 · 12 comments
Open

Adopt google.golang.org/protobuf #228

tlimoncelli opened this issue Dec 3, 2020 · 12 comments

Comments

@tlimoncelli
Copy link

This project imports github.com/golang/protobuf which is obsolete. Are there plans to switch to google.golang.org/protobuf ?

@firenessmax
Copy link

i have problem with the same import, my organization uses a dependency vulnerability check and give me some issues.
Captura de Pantalla 2021-03-30 a la(s) 19 25 07

@Deleplace
Copy link
Contributor

We should reopen and address this in some way

@jinglundong
Copy link
Collaborator

https://github.com/golang/appengine/releases/tag/v2.0.4 includes #314, which should have this fixed. Haven't verified it yet.

@aimuz
Copy link

aimuz commented Aug 18, 2023

Any progress on this issue?

@jinglundong
Copy link
Collaborator

https://github.com/golang/appengine/releases/tag/v2.0.4 should have this fixed. Could you share more details in case I missed anything?

@aimuz
Copy link

aimuz commented Aug 21, 2023

Ideally you should switch github.com/golang/protobuf to google.golang.org/protobuf

There is also code that is relying on this library github.com/golang/protobuf

"github.com/golang/protobuf/proto"

"github.com/golang/protobuf/proto"

@jinglundong
Copy link
Collaborator

ACK. I will try to share an update early next week. Sorry for not being able to stay on top of this issue.

@jkroepke
Copy link

@jinglundong do you have an update? Since the oauth2 package depends on appengine, the import of the deprecated package is spread across the half go universe (https://github.com/golang/oauth2/blob/master/go.mod)

@trakhimenok
Copy link
Contributor

image

Can we get some update on when we can expect not to download & compile 2 versions of the same thing?

@trakhimenok
Copy link
Contributor

Is anyone assigned to this?

@samiemad
Copy link

samiemad commented Oct 2, 2024

Any updates on this issue? I can see a couple of PRs attempting to solve it (#327 #346). Would it be possible to have a look at them?

@trakhimenok
Copy link
Contributor

4+ years since the issue opened and still even no ETA :(

Some communication regards status and plan would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants