-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sys/windows: uintptr(unsafe.Pointer) calls outside of syscalls #67437
Comments
CC @golang/runtime, @alexbrainman. |
CC @golang/windows I agree that this looks like a bug in x/sys/windows. I don't know how hard it would be to fix. |
@ianlancetaylor |
Change https://go.dev/cl/591475 mentions this issue: |
This is a duplicated of #59687. IMO @alexbrainman CL supersedes the one submitted in #59687. |
I implemented @mguy-huntress suggestion in https://go-review.googlesource.com/c/sys/+/591475 Hopefully it is good enough. Alex |
Documentation states:
However, there are calls within
/x/sys/windows
that do not follow this requirement. For an example, this call is casting anunsafe.Pointer
touintptr
then is then passed to hereThe generated calls in windows/zsyscall_windows.go should likely accept
unsafe.Pointer
arguments instead ofuintptr.
Examples
The text was updated successfully, but these errors were encountered: