go/types: missing Info.Types for *ast.FuncType

[adonovan]

In this program, types.Info.Types records no type for f's ast.FuncType node. I think it should:

package p

func f() (int, string) {
    return 0, "" 
}

@madelinekalil

[gabyhelp]

Related Issues

• go/types: missing Info.Types entry for variadic parameter *ast.Ellipsis #28277 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[Agent-Hellboy]

Hi @adonovan,

I’d like to work on this if @madelinekalil approve the issue. I’ve recently added a PR on a mini parser for go.mod, and the Go codebase looks clean and approachable. I am particularly interested in the parser, AST, and type-checking stages, and I want to contribute to these areas as they seem beginner-friendly and a great way to start learning a language's type system through hands-on experience.

patch:

diff --git a/src/go/types/signature.go b/src/go/types/signature.go
index 681eb85fd7..590e0a982b 100644
--- a/src/go/types/signature.go
+++ b/src/go/types/signature.go
@@ -106,12 +106,18 @@ func (s *Signature) String() string   { return TypeString(s, nil) }
 
 // funcType type-checks a function or method type.
 func (check *Checker) funcType(sig *Signature, recvPar *ast.FieldList, ftyp *ast.FuncType) {
        check.openScope(ftyp, "function")
        check.scope.isFunc = true
        check.recordScope(ftyp, check.scope)
        sig.scope = check.scope
        defer check.closeScope()
 
+       if check.Info.Types != nil {
+               check.recordTypeAndValue(ftyp, typexpr, sig, nil)
+       }
+
        // collect method receiver, if any
        var recv *Var
        var rparams *TypeParamList