Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinionated dependencies #19

Open
adborden opened this issue Oct 6, 2015 · 1 comment
Open

Opinionated dependencies #19

adborden opened this issue Oct 6, 2015 · 1 comment

Comments

@adborden
Copy link

adborden commented Oct 6, 2015

IMHO ;-) there are a lot of opinions in this library and only contributes to bloat. I feel like a test factory shouldn't have so many opinions. I wonder if some of these could be implemented as plugins instead. Some examples:

  • bluebird - not all projects are using promises
  • faker - I'm using faker in my project already. unionized is only using it for array random which is simple enough to implement.
  • goodeggs-json-schema-validator - the features it provides for unionized don't seem to be documented.
  • lodash - only used for type tests (isFunciton, isObject, etc)
  • randomstring - it's only used by goodeggs-json-schema-validator
  • objectid - also only used by goodeggs-json-validator
@hazeledmands
Copy link
Contributor

Thanks @adborden! You're totally right, a bunch of things have gotten unnecessarily coupled in this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants