-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding google/dagger #38
Comments
You're right that we should do this. I haven't figured out exactly how we should be interfacing with libraries that use bazel-common yet, so I'm hesitant to rush to something too quickly. But if you use bazel-common and then add a workspace dep on Dagger, everything should work |
Oh I suspect it will work, I just want bazel-common to do it for me :)
…On Sun, Nov 18, 2018 at 7:01 PM Ron Shapiro ***@***.***> wrote:
You're right that we should do this. I haven't figured out exactly how we
should be interfacing with libraries that use bazel-common yet, so I'm
hesitant to rush to something too quickly. But if you use bazel-common and
then add a workspace dep on Dagger, everything should work
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABQdkqjHVExIFsOz_0p61_fwvESDFwNks5uwh7rgaJpZM4YoJYB>
.
|
I think its probably best to just depend on the jars from maven, seems like Bazel-based integration is broken pretty badly at the moment. |
I don't think that's a reason to rush this unfortunately. I don't think it's something we want long term. But we can fix any of those issues (thanks for reporting them)! so that we can get things up to speed. |
Could be a worthwhile addition to this since it requires some annotation processor setup as well much like Auto.
The text was updated successfully, but these errors were encountered: