-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crane: GCR images are not up to date #1877
Comments
Almost certainly the CI/CD setup that publishes those images has bitrotted since I left Google, and I no longer have access to the GCP project that hosts the cloud build setup, sorry :/ Most of the people who used to maintain this repo now work at Chainguard, where we package a lot of open source software, including (I really don't mean for this to sound like a sales pitch.) Downside here is that only the latest version is provided for free, but if you're okay with only the latest release, consider switching to that (and I recommend digestabot to control the updates). If someone wants to migrate cloudbuild.yaml to GitHub Actions pushing to ghcr.io, I'd happily approve that as well. Maybe leave the existing |
This issue is stale because it has been open for 90 days with no |
I might give it a shot, unless someone is already working on this? |
Build container images on release and push them to ghcr. Fixes: google#1877 Signed-off-by: Jasper Orschulko <[email protected]>
@jonjohnsonjr I created a PR that should fix this and build & push container images to the ghcr during release. Only issue I am currently running into is that the container does not seem to pick up on the version: $ docker run --rm ghcr.io/jasper-ben/go-containerregistry/crane version
(devel) However, at least with the package installed from the arch package repository that is also the case. Could this be an unrelated issue? |
Build container images on release and push them to ghcr. Fixes: google#1877 Signed-off-by: Jasper Orschulko <[email protected]>
Build container images on release and push them to ghcr. Fixes: google#1877 Signed-off-by: Jasper Orschulko <[email protected]>
Hm that's a little weird -- does it work if you try to use the Commit? |
Tried that as well to no avail. I also checked the prebuilt binaries from the release page. They are returning the correct version 🤔 I am not too familiar with ko, but I think I used it correct here? ... |
The $ docker run -it --rm --entrypoint=/busybox/sh ghcr.io/jasper-ben/go-containerregistry/crane:debug
/ # Looking at the docs again, I think I might be using the |
Build container images on release and push them to ghcr. Fixes: google#1877 Signed-off-by: Jasper Orschulko <[email protected]>
Build container images on release and push them to ghcr. Fixes: google#1877 Signed-off-by: Jasper Orschulko <[email protected]>
Build container images on release and push them to ghcr. Update image locations in readme. Update container image link on release page. Fixes: google#1877 Signed-off-by: Jasper Orschulko <[email protected]>
This issue is stale because it has been open for 90 days with no |
Not stale, waiting for review |
@jonjohnsonjr Friendly ping to please review #2000 🙂 Has been ready for 3 months now and it would be great to have this included before the next release |
Describe the bug
Crane docker images that are intended to be available at
gcr.io/go-containerregistry/crane[version]
andgcr.io/go-containerregistry/crane/debug:[version]
are not currently up to date.It would appear the most recent docker container release for the GCR registry is August 2023
The docker images are documented as being available via the GCR registry over at https://github.com/google/go-containerregistry/blob/8dadbe76ff8c20d0e509406f04b7eade43baa6c1/cmd/crane/README.md#images
To Reproduce
docker run -it gcr.io/go-containerregistry/crane/debug:v0.19.0
Or
Expected behavior
Crane Images should be published to the GCR registries for each release
The text was updated successfully, but these errors were encountered: