Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggcr: from scratch images created using obsolete application/vnd.docker.distribution.manifest.v2+json mediaType #2012

Open
Silvanoc opened this issue Sep 19, 2024 · 2 comments · May be fixed by #2013
Labels
bug Something isn't working

Comments

@Silvanoc
Copy link

Describe the bug

empty.Image is creating an empty container image with the obsolete mediaType application/vnd.docker.distribution.manifest.v2+json

To Reproduce

See related issue GoogleContainerTools/kaniko#3319

Expected behavior

Empty container images are created with current expected mediaType application/vnd.oci.image.manifest.v1+json.

Additional context

As a consequence of this bug, Kaniko images built from scratch get the obsolete mediaType application/vnd.docker.distribution.manifest.v2+json and get rejected by OCI-only container registries (like ZOT).
As mentioned above, the related Kaniko issue related issue GoogleContainerTools/kaniko#3319 gives much more context information.

I have been looking for the moment when Docker switch their default format from their legacy one to the current OCI one, but I could not find it. It is in any case not a very recent change.

@jonjohnsonjr
Copy link
Collaborator

obsolete mediaType

I wouldn't go that far.

@Silvanoc
Copy link
Author

@jonjohnsonjr as you have probably recognized in the PR, I have been mixing Docker image format v1 and v2. You are right, that Docker image v2 is not obsolete. The fact all the images I have checked in the Docker Hub Library are in OCI v1 mislead me.

Nevertheless the issue that images built by Kaniko from scratch are created in Docker image v2, which gets rejected by OCI-only tools. I have to admit though, that Kaniko is not alone here. docker build itself also builds Docker image v2, what is somehow inconsistent with the above mentioned images in the Docker Hub Library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants