New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a cache for Data Layer DataStore #1480

Open

yschimke opened this issue Jul 10, 2023 · 2 comments

Labels

good first issue

Collaborator

yschimke commented Jul 10, 2023

See https://stackoverflow.com/questions/72935096/using-dataclient-getdataitem-as-storage-for-wear-over-datastore

We should also follow this advice and avoid reading directly through to the Data Client.

yschimke added the good first issue label

Collaborator Author

yschimke commented Oct 4, 2023

Mainly in DataStore module

https://github.com/google/horologist/blob/main/datalayer/core/src/main/java/com/google/android/horologist/data/store/impl/DataItemFlow.kt

this feature should probably wrap the standard Proto DataStore, but also synchronize the in the background with DataClient.

At the moment, it only reads from DataClient, which effectively means IPC to GMS?

Collaborator Author

yschimke commented Jun 14, 2024

We should look at adopting the InterProcessCoordinator

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:datastore/datastore-core/src/commonMain/kotlin/androidx/datastore/core/InterProcessCoordinator.kt?q=InterProcessCoordinator%20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment