Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some screenshot tests not completing #2237

Open
yschimke opened this issue May 20, 2024 · 5 comments
Open

Some screenshot tests not completing #2237

yschimke opened this issue May 20, 2024 · 5 comments

Comments

@yschimke
Copy link
Collaborator

TODO investigate
@yschimke
Copy link
Collaborator Author

DialogTest is one

@yschimke
Copy link
Collaborator Author

Raised https://issuetracker.google.com/issues/341880461

@yschimke
Copy link
Collaborator Author

Fixed in https://android-review.googlesource.com/c/platform/frameworks/support/+/3112159

@luizgrp
Copy link
Member

luizgrp commented Sep 18, 2024

I think there are some tests that should be re-enabled?

https://github.com/search?q=repo%3Agoogle%2Fhorologist%20https%3A%2F%2Fgithub.com%2Fgoogle%2Fhorologist%2Fissues%2F2237&type=code

@luizgrp luizgrp reopened this Sep 18, 2024
@yschimke
Copy link
Collaborator Author

I think we would need a cherry pick https://b.corp.google.com/issues/341880461 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yschimke @luizgrp