Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android_wear_capabilities and resource shrinker #2281

Open
Tolriq opened this issue Jun 27, 2024 · 7 comments · Fixed by #2385
Open

android_wear_capabilities and resource shrinker #2281

Tolriq opened this issue Jun 27, 2024 · 7 comments · Fixed by #2385

Comments

@Tolriq
Copy link
Contributor

Tolriq commented Jun 27, 2024

See: https://issuetracker.google.com/issues/348688201

But to resume tools:keep="@array/android_wear_capabilities" is not a valid way to ensure that the resource is kept when present inside the xml itself.
Docs should be amended with for example the solution from https://issuetracker.google.com/issues/348688201#comment4

@yschimke
Copy link
Collaborator

@yschimke yschimke changed the title android_wear_capabilities and ressource shrinker android_wear_capabilities and resource shrinker Aug 19, 2024
@oas004
Copy link
Contributor

oas004 commented Sep 13, 2024

@yschimke
Copy link
Collaborator

Yep, I can make those changes.

@Tolriq
Copy link
Contributor Author

Tolriq commented Sep 13, 2024

@oas004 @yschimke the PR is wrong.

The array list still needs to be in value, it's only the keep that needs to be extracted and put in the raw folder.

And BTW in the array file the "tools:keep="@array/android_wear_capabilities"" can be removed as it's the non working part it avoids mistakes.

@yschimke
Copy link
Collaborator

@Tolriq Thanks, I'll follow up with a test on the release target.

@oas004
Copy link
Contributor

oas004 commented Sep 29, 2024

@yschimke What is missing on this issue now? :) Is It something I should do? @Tolriq Does it look correct after the latest PR with adjustments? :)

@yschimke
Copy link
Collaborator

yschimke commented Sep 30, 2024

I just wanted to have a test that builds the release APK and confirms the resources. I'm happy to do it, but if you felt keen, go for it.

And maybe see if we can push the raw file up into library code and have apps built correctly if they just depend on horologist datalayer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants