Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Oops, this parser is just broken" #801

Closed
jenskutilek opened this issue May 16, 2024 · 7 comments
Closed

"Oops, this parser is just broken" #801

jenskutilek opened this issue May 16, 2024 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jenskutilek
Copy link

I tried to compile my Sudo font with fontc, but it fails without any specifics:

fontc Sudo.glyphs
Font IR error: 'Unable to parse "Sudo.glyphs": Unable to read glyphs file: Unable to parse Sudo.glyphs: Oops, this parser is just broken'

I converted the original .glyphspackage file to .glyphs, attached.

Sudo.glyphs.zip

@anthrotype
Copy link
Member

anthrotype commented May 16, 2024

thanks. Could you try with RUST_BACKTRACE=1 env variable and paste here what you get?

@anthrotype
Copy link
Member

actually RUST_BACKTRACE=1 would not work in this case as this is not a panic. RUST_LOG=debug maybe

@anthrotype
Copy link
Member

I put a few println! before the SomethingWentWrong error which gives the Ooops, and I think it's the "disabled = 1" key in some of the custom parameters that is making it fail. So the glyphs-reader parser currently doesn't support disabled custom parameters. Looks like it's a known issue #312

If I remove those disabled custom params, I get another error but probably better to file a separate issue for that.

@anthrotype
Copy link
Member

anthrotype commented May 16, 2024

ideally we should support parsing disabled custom params, but at least this generic error message should be made clearer, more specific

@jenskutilek
Copy link
Author

Thank you for testing!

@rsheeter
Copy link
Contributor

Thank you for the report

@rsheeter rsheeter added bug Something isn't working good first issue Good for newcomers labels May 16, 2024
@cmyr
Copy link
Member

cmyr commented Jul 29, 2024

this is fixed in #880

@cmyr cmyr closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants