Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I’m unable to set the licenseURL in a font, even though I can set related properties like manufacturerURL #994

Open
arrowtype opened this issue Mar 28, 2024 · 4 comments

Comments

@arrowtype
Copy link

arrowtype commented Mar 28, 2024

Expectation: GSFont(fontPath).licenseURL = "https://opensource.org/license/mit" should set a GlyphsApp font’s License URL to https://opensource.org/license/mit.

Current experience: The licenseURL attribute setter doesn’t seem to have any effect – even though related attributes such as manufacturerURL do work.

Reproduction case:
https://github.com/arrowtype/test-glyphslib-licenseURL-setter

Not sure if I’m doing something wrong, but this seems like it just doesn’t work.

I’ve tested this in glyphsLib 6.7.0, 6.6.6, and 6.6.5.

Please let me know if any more information would be helpful here. Thank you for taking a look!

PS: I’m also not sure if it’s related, but the GlyphsApp API docs don’t include a licenseURL font attribute. Please let me know if this should be related over in the GlyphsApp forum instead / in addition.

image
@schriftgestalt
Copy link
Collaborator

schriftgestalt commented May 4, 2024

that will work soon like this:

font.properties["licenseURL"] = "https://opensource.org/license/mit"

This is the preferred way to set font properties. The direct settlers are just there for convenience.

@arrowtype
Copy link
Author

Ah, great to know – thanks so much! (I suppose I can just keep an eye on this issue to catch when the support is added, or is there a particular PR already?)

@schriftgestalt
Copy link
Collaborator

It is in the branch "Glyphs3_merge".

@arrowtype
Copy link
Author

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants