This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
Remove pagination limit on label copy #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @skwi! Before I merge your patch, would you mind adding some UT using |
|
Yes I will. I should be able to find time this week to write the UT. To be honest, this is the first time I write code in Go so I need some time to find out why UT are now failing, but I'm working on it. |
No worries, thanks for your contribution. |
|
Related to #53 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While transfering a large amount of labels, I found my self limited to 20 by the Gitlab API pagination.
This PR fixes this issue by fetching label with a page loop.