Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor_link module to GovCMS #411

Open
adresden-opc opened this issue Feb 17, 2022 · 8 comments
Open

Add anchor_link module to GovCMS #411

adresden-opc opened this issue Feb 17, 2022 · 8 comments
Labels
blocked enhancement New feature or request module under investigation Request has been added to the D9 backlog to be investigated.

Comments

@adresden-opc
Copy link

** What value does this module/package add to GovCMS?

The ability to add name anchors and link to them is basic functionality.

** Please provide a brief outline of what this module does.

Adds a button to the ckeditor toolbar. Clicking the button adds a named anchor element to the edited page.

** Who does this module benefit:
[ ] end users
[ *] content editors
[ ] site builders
[ ] themers
[ ] developers

** How could you provide/replicate the functionality of this module using alternative methods, eg in your theme?

None

** If this module styles or alters HTML or JavaScript output, can the functionality be provided via the theme? What alternatives have you considered.

There are none.

** What is the maintenance and support status of the module. Describe the issue queue activity.

8.x-2.5 - 9 February 2021

** What permissions are needed to utilise the module (and are any new permissions provided by the module)?

None

** Does the module modify the database structure and/or store additional metadata on nodes or other entities? If so, why? What are the risks for future updates?

None

** Is the module designed to capture anonymous user data?

no.

** Is the output of the module typically fully cacheable? Would the inclusion of this module potentially render pages uncacheable.

n/a

** What is your assessment of the quality of this module, the contribution history of the module's maintainers, and the uptake of the module within the Drupal community?

Stable. Used correctly, it is a solid module.

** Additional information

@adresden-opc adresden-opc added the enhancement New feature or request label Feb 17, 2022
@thisisalistairsaccount
Copy link

Hi @adresden-opc we had this raised previously when we were working on Drupal 8 govCMS/GovCMS8#393

We are currently looking at this internally. To note, there's a dependency on the CKEditor Fake Objects https://www.drupal.org/project/fakeobjects that we also have to look as part of this.

@thisisalistairsaccount thisisalistairsaccount added module under investigation Request has been added to the D9 backlog to be investigated. labels Feb 22, 2022
@pellegs
Copy link

pellegs commented Mar 10, 2022

Issue raised with fakeobjects a blocker at this time
https://www.drupal.org/project/fakeobjects/issues/3118327

@thisisalistairsaccount
Copy link

For visibility, the issue raised at https://www.drupal.org/project/fakeobjects/issues/3118327 is still RTBC and hasn't been included.

To note, with the move away from CKEditor 4 to 5 (part of the Drupal 9.5 branch) also means the current release of acnhor_link (as of this comment) is only CKEditor 4 compatible. There is an issue raised at https://www.drupal.org/project/anchor_link/issues/3206676 around this, but is still early days.

Issue is still blocked.

@tumendelger
Copy link

Hello @thisisalistairsaccount,

Any update on this one? Will there be an inclusion of this module?

@thisisalistairsaccount
Copy link

Hi @tumendelger the same issues I've last flagged are still outstanding.

@StephenOllman
Copy link

Whilst a useful tool to have in the editor toolbar, anchor links are pretty easy to achieve using plain HTML.

@brett-sargeant
Copy link

It looks like it's been made compatible with CK5

@dibs
Copy link

dibs commented Aug 22, 2024

This would be a good addition for editors who may not feel as confident with HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request module under investigation Request has been added to the D9 backlog to be investigated.
Projects
None yet
Development

No branches or pull requests

7 participants