Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Notice: Undefined index: region in govcms8_uikit_starter_preprocess_block() #121

Open
OPCIT opened this issue Mar 31, 2020 · 7 comments
Open

Comments

@OPCIT
Copy link

OPCIT commented Mar 31, 2020

When assigning a menu to one or all of the 'Postscript' regions we are getting this error.

Notice: Undefined index: region in govcms8_uikit_starter_preprocess_block() (line 243 of themes/contrib/govcms8_uikit_starter/govcms8_uikit_starter.theme).

Disabling the menu in the regions removes the error.

@OPCIT
Copy link
Author

OPCIT commented Mar 31, 2020

Oh and this is only occurring on local devs, not in Sandbox which makes it more weird.

@OPCIT
Copy link
Author

OPCIT commented Apr 28, 2020

Code needs updating: govcms8_uikit_starter.theme (line 242)

`
/**

  • Implements hook_preprocess_block().
    */
    function govcms8_uikit_starter_preprocess_block(&$variables) {
    `
    .....

if (isset($variables["content"]["#menu_block_configuration"])) {

should be

if (isset($variables["content"]["#menu_block_configuration"]["region"])) {

@OPCIT
Copy link
Author

OPCIT commented May 28, 2020

Any update on having this issue corrected, or is it an edge case error?

@Belhendo
Copy link

hi @OPCIT

We're currently reviewing this internally to find a way to progress. It seems to be an edge case error at this stage.

@Belhendo
Copy link

Hi @OPCIT

Due to resource limitations at our end, our suggestion to progress this is as follows:

  • Fork the theme
  • Implement the fix
  • If you are willing and able, contribute a pull request back on the theme
  • Then we can look at it in due course

Thanks @OPCIT

@OPCIT
Copy link
Author

OPCIT commented Aug 13, 2020

@Belhendo

Seems this is no longer the case.

Hi Stephen,
The govcms8_uikit_starter repo is locked and it is not possible to push directly to it. You could forklift the project in Github and create a pull request, however, Finance team has advised me that there are no planned releases in near feature. We recommend forking the theme in your local projects and not depend on the Github project.
Please let me know if you have any question or concern.
Kind regards,
Ahmed.

@thisisalistairsaccount
Copy link

@OPCIT I think the fork is going to be the best option as per Ahmed's message. We do not have any planned releases for the kit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants