You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to propose a few tweaks to the Nginx helpers:
.docker/images/nginx/helpers
1: Can we rename these so they have numerical prefixes inline with the Amazee nginx config. This keeps things consistent and the load order predictable.
2: The Amazee location blocks all have the ability to include additional conf.d files before and after the location definition. This is really nice if you want to do extra stuff in them. Propose that for those helpers declaring a location, that include directives are added for this purpose and to bring them inline with the Amazee locations, for example:
# Only cache binary files for 30 minutes. These are the default allowed file extensions uploads that are not images.
location ~* ^/sites/default/files/.+\.(pdf|doc|...|webp|webm)$ {
include /etc/nginx/conf.d/drupal/location_expires_prepend*.conf;
expires 1800s;
include /etc/nginx/conf.d/drupal/location_expires_append*.conf;
}
In our case, we're using fastcgi_intercept_errors to do some nice things with error handling in sites/default/files and so we need to get a couple of directives into this specific location.
Will put up a PR for these changes shortly.
The text was updated successfully, but these errors were encountered:
I'd like to propose a few tweaks to the Nginx helpers:
.docker/images/nginx/helpers
1: Can we rename these so they have numerical prefixes inline with the Amazee nginx config. This keeps things consistent and the load order predictable.
2: The Amazee
location
blocks all have the ability to include additionalconf.d
files before and after the location definition. This is really nice if you want to do extra stuff in them. Propose that for those helpers declaring a location, thatinclude
directives are added for this purpose and to bring them inline with the Amazee locations, for example:In our case, we're using
fastcgi_intercept_errors
to do some nice things with error handling in sites/default/files and so we need to get a couple of directives into this specific location.Will put up a PR for these changes shortly.
The text was updated successfully, but these errors were encountered: